impl: add a retry with result function #2837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR @alevenberg! From the CI tests it looks like there are two linter errors to resolve:
update this line in Once these are resolved, the PR itself looks good and we should be able to merge |
|
Made the changes. Ran the following to format the files. |
|
Thanks for taking a look @aaron-prindle |
aaron-prindle
approved these changes
Nov 10, 2023
alevenberg
added a commit
to alevenberg/kaniko
that referenced
this pull request
Nov 10, 2023
* impl: add a retry with result function * fix ci errs
alevenberg
added a commit
to alevenberg/kaniko
that referenced
this pull request
Nov 14, 2023
* impl: add a retry with result function * fix ci errs
alevenberg
added a commit
to alevenberg/kaniko
that referenced
this pull request
Nov 14, 2023
* impl: add a retry with result function * fix ci errs
alevenberg
added a commit
to alevenberg/kaniko
that referenced
this pull request
Nov 14, 2023
* impl: add a retry with result function * fix ci errs
alevenberg
added a commit
to alevenberg/kaniko
that referenced
this pull request
Nov 14, 2023
* impl: add a retry with result function * fix ci errs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of the attempt to fix #1717
Description
This is 1/2 PRs. In the 2nd PR, I want to add a retry loop to
remoteImageFunc. This PR adds a function to retry when there is a return value.Submitter Checklist
- [ ] Adds integration tests if needed.Tested using
go test pkg/util/util_test.go pkg/util/util.goI tried
make testbut was getting failures on the main branch in unrelated tests, e.g.Reviewer Notes
Note: this is my first time using go in a while, if there are any readability changes I could make, please let me know!